fix(malloc): harden pprof output for Pyroscope malloc profiles#24197
Open
VioletQwQ-0 wants to merge 2 commits intomatrixorigin:mainfrom
Open
fix(malloc): harden pprof output for Pyroscope malloc profiles#24197VioletQwQ-0 wants to merge 2 commits intomatrixorigin:mainfrom
VioletQwQ-0 wants to merge 2 commits intomatrixorigin:mainfrom
Conversation
|
|
- Rename sample types to alloc_objects, alloc_space, inuse_objects, inuse_space; default inuse_space - Set PeriodType, Period, TimeNanos, and Mapping.HasFunctions in Profiler.Write - Add heap_profiler_pprof_test for profile.Parse round-trip - Add [malloc] block to mo_checkin_regression_tke.yaml for tp/dn Made-with: Cursor
VioletQwQ-0
force-pushed
the
violet/malloc-pyroscope-pr
branch
from
06fb6d1 to
d34c52c
Compare
fengttt
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens MatrixOne's custom
/debug/mallocpprof output for Pyroscope ingestion.Changes:
alloc_objectsalloc_spaceinuse_objectsinuse_spaceProfiler.Write:PeriodTypePeriodTimeNanosMapping.HasFunctionsprofile.Locationto the defaultprofile.Mappingprofile.Parse(...)p.CheckValid()Location.Mappingassertions[malloc]config fortp/dnWhy
We previously observed that:
/debug/mallocwas parseable bygo tool pprofmallocprofile typesnil pointer dereferenceThe remaining MatrixOne-side compatibility gap appeared to be
Location.Mapping == nilin the emitted profile.Validation
Repository-side:
Cluster-side:
mallocprofile types visible in Pyroscope APINotes
The cluster-side result suggests
Location.Mappingwas the main MatrixOne-side compatibility issue for custom malloc profile ingest. Longer soak / overhead validation is still planned separately inmo-auto-test.